[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243312#comment-13243312
]
stack commented on HBASE-5682:
------------------------------
This is a perversion.
If we pass in a connection from outside, down in the guts, do special handling
that makes the connection and zookeeper handling do reconnect. Its like we
should be passing an Interface made at a higher-level of abstraction and then
in the implementation, it did this fixup when connection breaks.
With that out of the way, do whatever you need to make it work. Patch looks
fine. How did you test. Would it be hard to make a unit test of it. A unit
test would be good codifying this perversion since it will be brittle being not
whats expected.
I'm against changing the behavior of the default case in 0.92/0.94. I'm
interested in problems you see in hbase-5153 or issues you have w/ the
implementation there that being the 0.96 client.
> Allow HConnectionImplementation to recover from ZK connection loss (for 0.94
> only)
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5682
> URL: https://issues.apache.org/jira/browse/HBASE-5682
> Project: HBase
> Issue Type: Improvement
> Components: client
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 5682-v2.txt, 5682.txt
>
>
> Just realized that without this HBASE-4805 is broken.
> I.e. there's no point keeping a persistent HConnection around if it can be
> rendered permanently unusable if the ZK connection is lost temporarily.
> Note that this is fixed in 0.96 with HBASE-5399 (but that seems to big to
> backport)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
