Apache9 commented on a change in pull request #436: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/436#discussion_r311103717
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -87,15 +83,15 @@ public static Throwable findException(Object exception) {
}
Throwable cur = (Throwable) exception;
while (cur != null) {
- if (isSpecialException(cur)) {
+ if (regionDefinitelyOnTheRegionServerException(cur)) {
Review comment:
I think here we still need the isSpecialException? Otherwise we may go into
the second condition where we get the cause of the exception for some
exceptions which are not in regionDefinitelyOnTheRegionServerException but
still in isSpecialException.
Of cource I do not think 'isSpecialException' is a good name, maybe we could
find another name for it, and makes it private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
