Apache9 commented on a change in pull request #436: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/436#discussion_r312311362
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -59,8 +59,7 @@ public static boolean isMetaClearingException(Throwable cur)
{
if (cur == null) {
return true;
}
- return !isSpecialException(cur) || (cur instanceof RegionMovedException)
- || cur instanceof NotServingRegionException;
+ return !regionDefinitelyOnTheRegionServerException(cur);
}
public static boolean isSpecialException(Throwable cur) {
Review comment:
OK, the problem for using regionDefinitelyOnTheRegionServerException
directly in findException is the name of the method... Maybe we could add a
other method which is called something like 'the exception we care', as the
intention there is that, if we hit these exceptions then we will not trying to
get the cause any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
