johnhomsea commented on a change in pull request #436: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/436#discussion_r312307209
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -59,8 +59,7 @@ public static boolean isMetaClearingException(Throwable cur)
{
if (cur == null) {
return true;
}
- return !isSpecialException(cur) || (cur instanceof RegionMovedException)
- || cur instanceof NotServingRegionException;
+ return !regionDefinitelyOnTheRegionServerException(cur);
}
public static boolean isSpecialException(Throwable cur) {
Review comment:
OK, I misunstood your comment, and thought your concern is the removal of
the public method isSpecialException. 1) The exceptions make
isSpecialException true are a subset of the complementary set of exceptions
that make regionDefinitelyOnTheRegionServerException true. So will use
!regionDefinitelyOnTheRegionServerException instead of isSpecialException.
2) MultiActionResultTooLarge is a subclass of RetryImmediatelyException,
which is there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
