johnhomsea commented on a change in pull request #436: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/436#discussion_r312309821
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##########
@@ -59,8 +59,7 @@ public static boolean isMetaClearingException(Throwable cur)
{
if (cur == null) {
return true;
}
- return !isSpecialException(cur) || (cur instanceof RegionMovedException)
- || cur instanceof NotServingRegionException;
+ return !regionDefinitelyOnTheRegionServerException(cur);
}
public static boolean isSpecialException(Throwable cur) {
Review comment:
> Make this private? And can we reuse the
regionDefinitelyOnTheRegionServerException so we can write less instance of
here? And MultiActionResultTooLarge is not included in
regionDefinitelyOnTheRegionServerException?
Here the isSpecialException is equivalent with
regionDefinitelyOnTheRegionServerException, the two more exceptions in
isSpecialException are RegionMovedException and RegionOpeningException. Both
of them are subclasses of NotServingRegionException, which is there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
