[
https://issues.apache.org/jira/browse/HBASE-5682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243619#comment-13243619
]
stack commented on HBASE-5682:
------------------------------
bq. The problem I have seen in 0.94/0.92 without this patch even with managed
connections is that after HConnection times out, it is unusable and even
getting a new HTable does not fix the problem since behind the scenes the same
HConnection is retrieved.
Didn't we add a check for if the connection is bad?
bq. Will think about an automated test. Do you like the version better that
always does the recheck (and hence all the conditional for "managed" go away)?
How does this work in trunk? In trunk the work has been done so we don't
really keep open a zk session any more. For the sake of making tests run
smoother, we'll do keep alive on zk session and hold it open 5 minutes and let
it go if unused.
I'm +1 on making our stuff more resilient. Resusing a dud hconnection either
because the connection is dead or zk session died is hard to figure.
How will this change a users's perception about how this stuff is used? If
your answer is that it helps in the extreme where the connection goes dead, and
thats the only change a user percieves, then lets commit. But we should
include a test? If you describe one, I can try help write it?
You think this should go into 0.92?
> Allow HConnectionImplementation to recover from ZK connection loss (for 0.94
> only)
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5682
> URL: https://issues.apache.org/jira/browse/HBASE-5682
> Project: HBase
> Issue Type: Improvement
> Components: client
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 5682-all.txt, 5682-v2.txt, 5682.txt
>
>
> Just realized that without this HBASE-4805 is broken.
> I.e. there's no point keeping a persistent HConnection around if it can be
> rendered permanently unusable if the ZK connection is lost temporarily.
> Note that this is fixed in 0.96 with HBASE-5399 (but that seems to big to
> backport)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
