openinx commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r313252250
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
##########
@@ -304,23 +303,23 @@ void refreshFileConnection(int accessFileNum,
IOException ioe) throws IOExceptio
}
private interface FileAccessor {
- int access(FileChannel fileChannel, ByteBuffer byteBuffer, long
accessOffset)
+ int access(FileChannel fileChannel, ByteBuff byteBuffer, long accessOffset)
Review comment:
byteBuffer -> byteBuff or buff ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
