openinx commented on a change in pull request #479: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#discussion_r314163983
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/RefCnt.java
##########
@@ -60,4 +64,30 @@ protected final void deallocate() {
public final ReferenceCounted touch(Object hint) {
throw new UnsupportedOperationException();
}
+
+ public void setInnerRefCnt(Optional<RefCnt> refCnt) {
Review comment:
The RefCnt is a general reference count class here... The refCnt with
interRefCnt is mainly used for BucketEntry ? Could we create a subclass for
BuckentEntry only ? I mean the general ByteBuff use the customized will be
resource-consuming ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
