saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix HBCK2 after HBASE-22777 & HBASE-22758 URL: https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314355466
########## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBCKConstants.java ########## @@ -0,0 +1,22 @@ +package org.apache.hbase.hbck1; + +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.yetus.audience.InterfaceAudience; + +/** + * HBCKConstants holds a bunch of HBase(HBCK)-related constants. + * hbck's local version of the HConstants from the hbase repo. + */ [email protected] +final class HBCKConstants { + /** + * Merge qualifier prefix. + * We used to only allow two regions merge; mergeA and mergeB. + * Now we allow many to merge. Each region to merge will be referenced + * in a column whose qualifier starts with this define. + */ + public static final String MERGE_QUALIFIER_PREFIX_STR = "merge"; + + public static final byte [] MERGE_QUALIFIER_PREFIX = + Bytes.toBytes(MERGE_QUALIFIER_PREFIX_STR); +} Review comment: We have Constants in hbase but this pulling out constants to be in their own file is an anti-pattern (Constants is a mistake). Constants should be beside where they are used. If shared, then put in base or first mention class or the class that looks best like a 'home' for the constant. FYI, new files need license. I see here you are pulling over the new regex facility. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
