saintstack commented on a change in pull request #14: HBASE-22843 [HBCK2] Fix 
HBCK2 after HBASE-22777 & HBASE-22758
URL: 
https://github.com/apache/hbase-operator-tools/pull/14#discussion_r314364428
 
 

 ##########
 File path: 
hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsckRepair.java
 ##########
 @@ -200,6 +200,6 @@ public static HRegion createHDFSRegionDir(Configuration 
conf,
    */
   public static void removeParentInMeta(Configuration conf, RegionInfo hri) 
throws IOException {
     Connection conn = ConnectionFactory.createConnection(conf);
-    MetaTableAccessor.deleteRegion(conn, hri);
 
 Review comment:
   So, old HBCK2 won't be able to talk to newer hbase. Ok. We need to update 
doc on HBCK2 to say use newest version. I think that is ok. HBCK2 should nearly 
always be newere than the hbase it is probling. Means that in the field there 
will be some interesting failures if old HBCK2... but should be 
self-explanatory (method does not exist!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to