brfrn169 commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-523071494 Thank you for your comment. @saintstack > 1. We are adding this to hbase itself rather than to hbase-operator-tools; would be good if it could live outside of hbase. That said, I could go with having it committed to hbase initially and then moved out later if made sense. I think we can move it to hbase-operator-tools (and it's not hard actually), but one more reason why I want to add it to hbase itself is that we will be able to run hbtop without installation (we can just run `hbase top` command). I think this feature is useful for hbase administrators, so being able to use it easily may be wanted. > 2. We're adding a terminal and a console windowing system. Poking around I see some overlap but I don't know enough to say if doing it all ourselves is way to go or even if its possible to add this as is and then later backfill with libraries. For example, what if we wanted to add color to hbtop (does it do color?), would we have to implement it ourselves? Or if we wanted to change style? I was looking for a terminal UI library after deciding not to use Lanterna bacause of the license problem, but I couldn't find a good one. And I made an abstraction layer for Terminal (https://github.com/apache/hbase/pull/476/files#diff-c7618b5d136137dad5dfefe94d122a41), so we can create another implementation for terminal when we find a good library. And actually, I made basic features for colors (BLACK, RED, GREEN, YELLOW, BLUE, MAGENTA, CYAN, WHITE: https://github.com/apache/hbase/pull/476/files#diff-8450df172184da9574f33a1db9e472d3) and styles (bold, blink, reverse, underline: https://github.com/apache/hbase/pull/476/files#diff-ad03be5d68e8d3eceabbd62c0af1e137) for the future. But someone might know a good library. So I will wait for others' comment. > I'd be game for committing this but can we get more reviewers? I see you asking for them and it is a big feature so it is hard to get the attention of busy folks. Have you put a request up on the dev list? Add a link to your fancy readme... so folks can see how fancy your lovely contrib is? Sure. Will put a review request on the dev list.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
