Apache9 commented on a change in pull request #513: HBASE-22867 The
ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster
with thousands table
URL: https://github.com/apache/hbase/pull/513#discussion_r316191549
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/DirScanPool.java
##########
@@ -100,8 +109,8 @@ synchronized void tryUpdatePoolSize(long timeout) {
}
}
shutdownNow();
- LOG.info("Update chore's pool size from {} to {}", pool.getParallelism(),
size);
- pool = new ForkJoinPool(size);
+ LOG.info("Update chore's pool size from {} to {}", pool.getPoolSize(),
size);
+ pool = initializePool(size);
Review comment:
For ThreadPoolExecutor, there is a setCorePoolSize method so we do not need
to recreate it. I think we can make it as a final member.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
