Apache9 commented on a change in pull request #513: HBASE-22867 The
ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster
with thousands table
URL: https://github.com/apache/hbase/pull/513#discussion_r316190965
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/DirScanPool.java
##########
@@ -73,8 +82,8 @@ synchronized void latchCountDown() {
notifyAll();
}
- synchronized void execute(ForkJoinTask<?> task) {
- pool.execute(task);
+ synchronized void runAsync(Runnable runnable) {
+ CompletableFuture.runAsync(runnable, pool);
Review comment:
Emmm, what is this used for? The method will return a CompletableFuture but
we just ignore it? Then what is the difference comparing to just call
pool.execute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
