HorizonNet commented on a change in pull request #547: HBASE-22899 logging
improvements for snapshot operations w/large manifests
URL: https://github.com/apache/hbase/pull/547#discussion_r318306980
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
##########
@@ -640,10 +645,12 @@ private void cloneHdfsMobRegion(final Map<String,
SnapshotRegionManifest> region
private void cloneRegion(final Path regionDir, final RegionInfo
snapshotRegionInfo,
final SnapshotRegionManifest manifest) throws IOException {
final String tableName = tableDesc.getTableName().getNameAsString();
+ final String snapshotName = snapshotDesc.getName();
for (SnapshotRegionManifest.FamilyFiles familyFiles:
manifest.getFamilyFilesList()) {
Path familyDir = new Path(regionDir,
familyFiles.getFamilyName().toStringUtf8());
for (SnapshotRegionManifest.StoreFile storeFile:
familyFiles.getStoreFilesList()) {
- LOG.info("Adding HFileLink " + storeFile.getName() + " to table=" +
tableName);
+ LOG.info("Adding HFileLink " + storeFile.getName() +" from clone
region " + "of snapshot " +
Review comment:
NIT: ` from cloned region ` and `in snapshot `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
