HorizonNet commented on a change in pull request #547: HBASE-22899 logging
improvements for snapshot operations w/large manifests
URL: https://github.com/apache/hbase/pull/547#discussion_r318306311
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
##########
@@ -523,20 +524,21 @@ private void restoreRegion(final RegionInfo regionInfo,
// Remove hfiles not present in the snapshot
for (String hfileName: familyFiles) {
Path hfile = new Path(familyDir, hfileName);
- LOG.trace("Removing hfile=" + hfileName +
+ LOG.trace("Removing HFile=" + hfileName + " not present in
snapshot=" + snapshotName+
" from region=" + regionInfo.getEncodedName() + " table=" +
tableName);
HFileArchiver.archiveStoreFile(conf, fs, regionInfo, tableDir,
family, hfile);
}
// Restore Missing files
for (SnapshotRegionManifest.StoreFile storeFile: hfilesToAdd) {
- LOG.debug("Adding HFileLink " + storeFile.getName() +
+ LOG.debug("Restore missing HFileLink " + storeFile.getName() +
Review comment:
NIT: `Restoring ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
