[
https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245950#comment-13245950
]
Shaneal Manek commented on HBASE-5706:
--------------------------------------
On consideration, I think JD and Andrew are right. It's relatively expensive to
log (although we're talking less than a micro of overhead per PUT near as I can
tell) and, more importantly, not at all actionable. We could make the queue
size tweakable via configs, but I don't think that's something users should
have to care about.
So let's just get rid of it. I've attached a patch that seems to apply cleanly
to 0.94/0.96/trunk.
Thanks for pointing it out! I think I'm just used to working on smaller
projects where the original devs are the only ones who will ever see the system
logs ;-) I'm personally interested in that log message out of idle curiosity,
but users of HBase do not (and should not) care.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping
> fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will
> be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed
> "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
