[
https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246004#comment-13246004
]
Hadoop QA commented on HBASE-5706:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521260/HBASE-5706.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1383//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1383//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1383//console
This message is automatically generated.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping
> fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will
> be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed
> "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
