joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320858193
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
##########
@@ -117,6 +118,19 @@ public static void addNamespaceQuota(final Connection
connection, final String n
public static void deleteNamespaceQuota(final Connection connection, final
String namespace)
throws IOException {
+ // Before removing namespace quota , remove quota from the tables inside
the namespace
+ // which does not have explicit space quotas defined on them.
+ TableName[] tableNames = QuotaUtil.listTableNamesByNamepsace(connection,
namespace);
Review comment:
This case should never happen. You can't delete a namespace which has tables
in it. If we're cleaning up a namespace, we shouldn't have any table-level
quotas hanging around.
Please log a `WARN` stating that we found a quota entry that shouldn't exist
and that we're going to remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
