joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r321765756
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java
##########
@@ -78,6 +79,20 @@ public void postDeleteTable(
admin.setQuota(settings);
}
}
+ } else if (quotasAtNamespace != null) {
+ // If quota present at namespace level remove the table entry from
'hbase:quota'
Review comment:
> Currently , table will be in violation even though it doesn't have any
data in it since it's entry was not deleted from 'hbase:quota'.
So let's say you have `t1` and `t1'` which are the two instances of the
tables as you describe.
If I had to guess, when you create `t1'`, the system would still see the
`t1`'s region size reports for a period of time (until `t1'` reports its for
the first time).
If this is indeed what's happening, the fix would be to purge the region
size reports for a table when it's deleted, not try to alter the state of
`hbase:quota`. Region size reports are held in memory inside of the active
HBase Master inside of the class `MasterQuotaManager`. There _is no_ quota
defined at the table level, so, again, I'm not sure what you expect this change
to be doing directly. If your test works, I can only imagine that it's by
circumstance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
