busbey commented on a change in pull request #580: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/580#discussion_r324433951
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java ########## @@ -119,8 +119,35 @@ * </li> * </ol> */ [email protected] -public final class Canary implements Tool { [email protected](HBaseInterfaceAudience.TOOLS) +public class Canary implements Tool, CanaryInterface { Review comment: Yeah please make the interface Canary and the tool CanaryTool or CanaryImpl or something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
