saintstack commented on issue #580: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/580#issuecomment-531503538 > Outstanding questions that I need help from community. > > Does it make sense to have "daemon" flag via api usage ? > Should we allow using "interval" argument via api. If I specify interval it means canary will run every "interval" seconds. > There are 3 properties which fails on error. -f, -treatFailureAsError, -failureArError > Can we just create 1 conf property for usage via API. We still will support all 3 arguments via ToolRunner interface. > How to figure out which constructor for CanaryInterface to expose ? > Do we need to instantiate executor if it is null ? Today Canary has one constructor which accepts executor as argument. We never verify whether the passed executor is instantiated or not. Feels like bug to me. Or is it understood that if someone calls that constructor, its his/her responsibility to instantiate executor. On 'daemon' api option, it is an odd option to expose IMO. Would think it daemon would be set always when calling something via API (i.e. in context). Interval as argument seems fine. What you thinking? One error option makes sense. " Feels like bug to me. " Me too. From an API, I'd think you'd be passing an executor?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
