joshelser commented on a change in pull request #598: HBASE-22142 Space quota: 
If table inside namespace having space quota is dropped, data size usage is 
still considered for the drop table.
URL: https://github.com/apache/hbase/pull/598#discussion_r325824776
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java
 ##########
 @@ -740,5 +740,14 @@ public void 
processFileArchivals(FileArchiveNotificationRequest request, Connect
       notifier.addArchivedFiles(filesWithSize);
     }
   }
+
+  /**
+   * Remove regionInfo entry for the table which is going to get dropped.
 
 Review comment:
   Can you change this to: "Removes each region size entry where the RegionInfo 
references the provided TableName". A little more clear about what this method 
does (instead of the context in which you are calling it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to