joshelser commented on a change in pull request #598: HBASE-22142 Space quota:
If table inside namespace having space quota is dropped, data size usage is
still considered for the drop table.
URL: https://github.com/apache/hbase/pull/598#discussion_r325827019
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaDropTable.java
##########
@@ -87,6 +94,50 @@ public void testSetQuotaAndThenDropTableWithDisable()
throws Exception {
setQuotaAndThenDropTable(SpaceViolationPolicy.DISABLE);
}
+ @Test
+ public void testSetQuotaAndThenDropTableWithRegionReport() throws Exception {
+ final TableName tn = helper.createTable();
+ helper.setQuotaLimit(tn, SpaceViolationPolicy.NO_INSERTS, 1L);
+ helper.writeData(tn, 2L);
+
+ final HMaster master = TEST_UTIL.getMiniHBaseCluster().getMaster();
+ final MasterQuotaManager quotaManager = master.getMasterQuotaManager();
+
+ // Make sure the master has report for the table.
+ Waiter.waitFor(TEST_UTIL.getConfiguration(), 30 * 1000, new
Waiter.Predicate<Exception>() {
+ @Override
+ public boolean evaluate() throws Exception {
+ Map<RegionInfo, Long> regionSizes = quotaManager.snapshotRegionSizes();
+ List<RegionInfo> tableRegions =
+ MetaTableAccessor.getTableRegions(TEST_UTIL.getConnection(), tn);
+ return regionSizes.containsKey(tableRegions.get(0));
+ }
+ });
+
+ boolean beforeDrop = false;
Review comment:
How about `hasRegionSize` instead of `beforeDrop`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
