busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/623#discussion_r325956315
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -362,11 +508,375 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
abortWriter(mobFileWriter);
}
}
+ // Commit or abort generational writers
+ if (mobWriters != null) {
+ for (StoreFileWriter w: mobWriters.getOutputWriters()) {
+ Long mobs = mobWriters.getMobCountForOutputWriter(w);
+ if (mobs != null && mobs > 0) {
+ mobRefSet.get().add(w.getPath().getName());
+ w.appendMetadata(fd.maxSeqId, major, mobs);
Review comment:
add a comment about what we expect to happen if we hit an IOException while
doing these writes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
