busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/623#discussion_r327191470
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java ########## @@ -907,6 +789,143 @@ public static boolean hasMobColumns(TableDescriptor htd) { return false; } + /** + * Get list of Mob column families (if any exists) + * @param htd table descriptor + * @return list of Mob column families + */ + public static List<ColumnFamilyDescriptor> getMobColumnFamilies(TableDescriptor htd){ + + List<ColumnFamilyDescriptor> fams = new ArrayList<ColumnFamilyDescriptor>(); + ColumnFamilyDescriptor[] hcds = htd.getColumnFamilies(); + for (ColumnFamilyDescriptor hcd : hcds) { + if (hcd.isMobEnabled()) { + fams.add(hcd); + } + } + return fams; + } + + /** + * Performs housekeeping file cleaning (called by MOB Cleaner chore) + * @param conf configuration + * @param table table name + * @throws IOException + */ + public static void cleanupObsoleteMobFiles(Configuration conf, TableName table) + throws IOException { + + try (final Connection conn = ConnectionFactory.createConnection(conf); + final Admin admin = conn.getAdmin();) { + TableDescriptor htd = admin.getDescriptor(table); + List<ColumnFamilyDescriptor> list = getMobColumnFamilies(htd); + if (list.size() == 0) { + LOG.info("Skipping non-MOB table [" + table + "]"); + return; + } + Path rootDir = FSUtils.getRootDir(conf); + Path tableDir = FSUtils.getTableDir(rootDir, table); + // How safe is this call? + List<Path> regionDirs = FSUtils.getRegionDirs(FileSystem.get(conf), tableDir); + + Set<String> allActiveMobFileName = new HashSet<String>(); Review comment: this is potentially a very large set. as we go we should periodically check the size and issue a WARN if it's getting very large, e.g. in the GB range. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services