Reidddddd commented on a change in pull request #615: HBASE-22975 Add read and
write QPS metrics at server level and table level
URL: https://github.com/apache/hbase/pull/615#discussion_r326095727
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -6598,6 +6605,9 @@ public boolean nextRaw(List<Cell> outResults,
ScannerContext scannerContext)
// scanner is closed
throw new UnknownScannerException("Scanner was closed");
}
+ if (rsServices != null && rsServices.getMetrics() != null) {
+
rsServices.getMetrics().updateReadQueryMeter(getRegionInfo().getTable());
+ }
Review comment:
Is the place right? The `readRequestsCount` is after outResults fetched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
