Reidddddd commented on a change in pull request #615: HBASE-22975 Add read and
write QPS metrics at server level and table level
URL: https://github.com/apache/hbase/pull/615#discussion_r326096145
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -6201,7 +6205,10 @@ String prepareBulkLoad(byte[] family, String srcPath,
boolean copyFile)
boolean isSuccessful = false;
try {
this.writeRequestsCount.increment();
-
+ if (rsServices != null && rsServices.getMetrics() != null) {
+ rsServices.getMetrics().updateWriteQueryMeter(this.htableDescriptor.
+ getTableName());
+ }
Review comment:
The write meter update should place after write execution, it is different
from `writeRequestsCount` because execution time matters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
