saintstack commented on a change in pull request #656: HBASE-23063 Add an 
option to enable multiget in parallel
URL: https://github.com/apache/hbase/pull/656#discussion_r327937217
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcCallContext.java
 ##########
 @@ -89,18 +91,17 @@
    */
   long getResponseCellSize();
 
+  long getNumsOfGet();
+
+  long incrementGetsNum();
+
   /**
-   * Add on the given amount to the retained cell size.
-   *
-   * This is not thread safe and not synchronized at all. If this is used by 
more than one thread
-   * then everything will break. Since this is called for every row 
synchronization would be too
-   * onerous.
+   * Method to account for the size of retained cells and retained data blocks.
+   * @param result result to add size.
    */
-  void incrementResponseCellSize(long cellSize);
-
-  long getResponseBlockSize();
 
 Review comment:
   Did these get removed? Is that ok?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to