virajjasani commented on a change in pull request #673: HBASE-23093 : Avoid
Optional Anti-Pattern where possible
URL: https://github.com/apache/hbase/pull/673#discussion_r332395568
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##########
@@ -281,7 +281,7 @@ void clearMasterStubCache(MasterService.Interface stub) {
masterStub.compareAndSet(stub, null);
}
- Optional<ServerStatisticTracker> getStatisticsTracker() {
+ ServerStatisticTracker getStatisticsTracker() {
Review comment:
This is just to simplify as we are putting this returned value directly as
argument to some methods.
e.g.
https://github.com/apache/hbase/pull/673/files#diff-6705e0c1d8285fddc3d939ad3352b1a6R310
https://github.com/apache/hbase/pull/673/files#diff-e12d4030edb8885f06f86ee77cfb5b0cR383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
