anoopsjohn commented on a change in pull request #707: HBASE-23066 Allow cache
on write during compactions when prefetching …
URL: https://github.com/apache/hbase/pull/707#discussion_r334747350
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
##########
@@ -81,6 +81,13 @@
*/
public static final String PREFETCH_BLOCKS_ON_OPEN_KEY =
"hbase.rs.prefetchblocksonopen";
+ /**
+ * Configuration key to cache blocks when a compacted file is written,
predicated on prefetching
+ * being enabled for the column family.
+ */
+ public static final String PREFETCH_COMPACTED_BLOCKS_ON_WRITE_KEY =
Review comment:
A bit confusing.. Are we doing the prefetch of the new compacted file once
it is written?
Dont think so.. When we write the file, that time itself the caching
happens. So it is cache on write. Why its called prefetch then? There is no
extra fetch op happening right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
