anoopsjohn commented on a change in pull request #707: HBASE-23066 Allow cache
on write during compactions when prefetching …
URL: https://github.com/apache/hbase/pull/707#discussion_r334747636
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
##########
@@ -319,6 +337,13 @@ public boolean shouldPrefetchOnOpen() {
return this.prefetchOnOpen;
}
+ /**
+ * @return true if blocks should be cached while writing during compaction,
false if not
+ */
+ public boolean shouldCacheCompactedBlocksOnWrite() {
+ return this.prefetchCompactedDataOnWrite && this.prefetchOnOpen;
Review comment:
Oh.. So the cache on write (at compaction) happens iff prefetch config is ON
! Anyways in ur case the prefetch which is another config, is ON right? I
think this is the reason why the new config you have named that way. But some
how I feel that config name is bit misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
