brfrn169 commented on a change in pull request #722: HBASE-23065 [hbtop] Top-N
heavy hitter user and client drill downs
URL: https://github.com/apache/hbase/pull/722#discussion_r336784393
##########
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/ModeStrategy.java
##########
@@ -33,6 +34,7 @@
interface ModeStrategy {
List<FieldInfo> getFieldInfos();
Field getDefaultSortField();
- List<Record> getRecords(ClusterMetrics clusterMetrics);
+ List<Record> getRecords(ClusterMetrics clusterMetrics,
+ @Nullable List<RecordFilter> pushDownFilters);
Review comment:
Do we need `@Nullable` here? It looks like `pushDownFilters` is always not
null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services