saintstack commented on a change in pull request #753: HBASE-23181 Blocked WAL
archive: "LogRoller: Failed to schedule flush…
URL: https://github.com/apache/hbase/pull/753#discussion_r339193734
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ImmutableByteArray.java
##########
@@ -51,4 +51,8 @@ public static ImmutableByteArray wrap(byte[] b) {
public String toStringUtf8() {
return Bytes.toString(b);
}
+
+ public String toStringBinary() {
+ return Bytes.toStringBinary(b);
+ }
Review comment:
When would we ever want a String that had binary non-printables in it? What
good is a toString that just does default Object#toString?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
