saintstack commented on a change in pull request #753: HBASE-23181 Blocked WAL
archive: "LogRoller: Failed to schedule flush…
URL: https://github.com/apache/hbase/pull/753#discussion_r339290979
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
##########
@@ -1001,8 +1001,13 @@ protected final boolean append(W writer, FSWALEntry
entry) throws IOException {
doAppend(writer, entry);
assert highestUnsyncedTxid < entry.getTxid();
highestUnsyncedTxid = entry.getTxid();
- sequenceIdAccounting.update(encodedRegionName, entry.getFamilyNames(),
regionSequenceId,
- entry.isInMemStore());
+ if (entry.isCloseRegion()) {
+ // let's clean all the records of this region
+ sequenceIdAccounting.onRegionClose(encodedRegionName);
+ } else {
+ sequenceIdAccounting.update(encodedRegionName, entry.getFamilyNames(),
regionSequenceId,
+ entry.isInMemStore());
Review comment:
The isInMemStore flag is there currently? No? I'm not advocating adding
anything not already present.
Looking at this patch, the new methods appendData and appendMarker do not
seem to buy us much. They do not go deep enough down into AbstractFSWAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
