virajjasani commented on a change in pull request #773: HBASE-23212 : Dynamically reload configs for Region Recovery chore URL: https://github.com/apache/hbase/pull/773#discussion_r340820480
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryConfigManager.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.master; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.ChoreService; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.conf.ConfigurationObserver; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Config manager for RegionsRecovery Chore - Dynamically reload config and update chore + * accordingly + */ [email protected] +public class RegionsRecoveryConfigManager implements ConfigurationObserver { + + private static final Logger LOG = LoggerFactory.getLogger(RegionsRecoveryConfigManager.class); + + private final HMaster hMaster; + private int oldMaxStoreFileRefCount; + private int oldRegionsRecoveryInterval; + + RegionsRecoveryConfigManager(final HMaster hMaster, + final Configuration conf) { + this.hMaster = hMaster; + this.oldMaxStoreFileRefCount = getMaxStoreFileRefCount(conf); + this.oldRegionsRecoveryInterval = getRegionsRecoveryChoreInterval(conf); + } + + @Override + public void onConfigurationChange(Configuration conf) { + synchronized (this.hMaster) { + final int newMaxStoreFileRefCount = getMaxStoreFileRefCount(conf); + final int newRegionsRecoveryInterval = getRegionsRecoveryChoreInterval(conf); + + LOG.info("Config Reload for RegionsRecovery Chore. oldMaxStoreFileRefCount: {}," + + " newMaxStoreFileRefCount: {}, oldRegionsRecoveryInterval: {}, " + + "newRegionsRecoveryInterval: {}", oldMaxStoreFileRefCount, newMaxStoreFileRefCount, + oldRegionsRecoveryInterval, newRegionsRecoveryInterval); + + if (oldMaxStoreFileRefCount == newMaxStoreFileRefCount + && oldRegionsRecoveryInterval == newRegionsRecoveryInterval) { + // no need to re-schedule the chore with updated config + // as there is no change in desired configs + return; + } + + RegionsRecoveryChore regionsRecoveryChore = new RegionsRecoveryChore(this.hMaster, + conf, this.hMaster); + ChoreService choreService = this.hMaster.getChoreService(); + + // Regions Reopen based on very high storeFileRefCount is considered enabled + // only if hbase.regions.recovery.store.file.ref.count has value > 0 + + if (newMaxStoreFileRefCount > 0) { + if (choreService.isChoreScheduled(regionsRecoveryChore)) { Review comment: Chore interval might also get updated which we might want to change too and also cancelChore() with 2nd arg false will ensure that if the chore was currently running then it is first completed and then unscheduled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
