virajjasani commented on a change in pull request #773: HBASE-23212 : Dynamically reload configs for Region Recovery chore URL: https://github.com/apache/hbase/pull/773#discussion_r341536007
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryConfigManager.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.master; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.ChoreService; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.conf.ConfigurationObserver; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Config manager for RegionsRecovery Chore - Dynamically reload config and update chore + * accordingly + */ +@InterfaceAudience.Private +public class RegionsRecoveryConfigManager implements ConfigurationObserver { + + private static final Logger LOG = LoggerFactory.getLogger(RegionsRecoveryConfigManager.class); + + private final HMaster hMaster; + private int prevMaxStoreFileRefCount; + private int prevRegionsRecoveryInterval; + + RegionsRecoveryConfigManager(final HMaster hMaster, + final Configuration conf) { Review comment: Since this is during initialization from HMaster only, is it fine to keep this way? In fact I thought of it but most of chores follow this way. thought? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
