wchevreuil commented on a change in pull request #781: HBASE-18095: Zookeeper-less client connection implementation URL: https://github.com/apache/hbase/pull/781#discussion_r341853924
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java ########## @@ -213,6 +213,10 @@ private volatile AsyncClusterConnection asyncConnection; + // Tracks any other connections created with custom client config. Used for testing clients with custom + // configurations. Tracked here so that they can be cleaned up on close() / restart. + private List<AsyncClusterConnection> customConnections = Collections.synchronizedList(new ArrayList<>()); + Review comment: I didn't quite follow why you needed to define these extra connections. Are you using both types of registry implementation on a single util instance? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
