wchevreuil commented on a change in pull request #781: HBASE-18095:
Zookeeper-less client connection implementation
URL: https://github.com/apache/hbase/pull/781#discussion_r342472984
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegistryFactory.java
##########
@@ -27,7 +27,7 @@
@InterfaceAudience.Private
final class AsyncRegistryFactory {
- static final String REGISTRY_IMPL_CONF_KEY = "hbase.client.registry.impl";
+ public static final String REGISTRY_IMPL_CONF_KEY =
"hbase.client.registry.impl";
Review comment:
Same concern here. My understanding now, is that both server and client will
rely on same config property, which may seem error prone to me. That's why I
mention on my previous comment that maybe we should think on split the
connection creation path between server and client based callers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
