bharathv commented on a change in pull request #781: HBASE-18095: Zookeeper-less client connection implementation URL: https://github.com/apache/hbase/pull/781#discussion_r341877344
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java ########## @@ -213,6 +213,10 @@ private volatile AsyncClusterConnection asyncConnection; + // Tracks any other connections created with custom client config. Used for testing clients with custom + // configurations. Tracked here so that they can be cleaned up on close() / restart. + private List<AsyncClusterConnection> customConnections = Collections.synchronizedList(new ArrayList<>()); + Review comment: I did this because I want to use different server and client side configs. The default Connection object built (in initConnection()) is using the server side conf. We cannot use the same conf for this patch, because we need the service side meta/master tracking to happen using ZK and just the client side to use HMasterAsyncRegistry. Is there a cleaner way to do this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
