bharathv commented on a change in pull request #781: HBASE-18095:
Zookeeper-less client connection implementation
URL: https://github.com/apache/hbase/pull/781#discussion_r342723614
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegistryFactory.java
##########
@@ -27,7 +27,7 @@
@InterfaceAudience.Private
final class AsyncRegistryFactory {
- static final String REGISTRY_IMPL_CONF_KEY = "hbase.client.registry.impl";
+ public static final String REGISTRY_IMPL_CONF_KEY =
"hbase.client.registry.impl";
Review comment:
Agree with the comments. Like @apurtell mentioned in another comment, I will
work towards making this the default registry implementation for both clients
and internal service connections (except Master which obviously goes to ZK, the
source of truth). There is nothing in the implementation that prevents this. It
was only done because the HBaseMiniCluster used in tests picks random ports
(for running concurrent tests) and the clients don't know before hand what
would the correct master port to use in the config.
So if you see the pattern in tests, we wait for the mini cluster to be up,
get the running master and it's port and then create a new Connection object
based on that config. Once I figure out a way to force the mini-cluster to use
certain known ports (without affecting the test concurrency ofcourse), we can
get rid of the whole custom-config / split-config business. I'm looking into
it. Hope it clarifies the intention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
