bharathv commented on a change in pull request #809: HBASE-23261 : Processing 
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344314816
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
 ##########
 @@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw, 
HRegionInfo region,
     try {
       rt = RegionTransition.createRegionTransition(
           endState, region.getRegionName(), serverName, payload);
-      if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+      boolean isDataSet;
+      try {
+        isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(), 
stat.getVersion());
+      } catch (KeeperException.BadVersionException e) {
+        isDataSet = false;
+        LOG.info("Received BadVersionException from ZK for " + encoded
 
 Review comment:
   nit: Always better to use parameterized logging for performance [1]. Here 
info is the default, so probably doesn't matter as much. 
   
   [1] https://logging.apache.org/log4j/2.x/performance.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to