bharathv commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344324610
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##########
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+ isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
+ isDataSet = false;
+ LOG.info("Received BadVersionException from ZK for " + encoded
Review comment:
I see ok. Looks like branch-1.3 also pulls in slf4j dependency and quite a
few places use it. For ex:
https://github.com/apache/hbase/blob/branch-1.3/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L428
but I see your point that there is no standard usage pattern there. Anyway
this comment was not meant to be a blocker for merging. Feel free to fix it if
you have free cycles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services