[ 
https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249937#comment-13249937
 ] 

Hudson commented on HBASE-5744:
-------------------------------

Integrated in HBase-TRUNK-security #164 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/164/])
    [jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of 
int

Summary: As we measure our Thrift call latencies in nanoseconds, we need to make
latencies long instead of int everywhere. There is a bug where we truncate a
nanosecond latency to int, which is a problem with RPCs that take more than
2.147483647 seconds to process.

Test Plan:
TestThriftServer is updated to test for the failure case (an RPC is artificially
made to take 3 seconds). The new test case fails without the fix.

Re-run all unit tests.

Reviewers: sc, dhruba, Kannan, Liyin, JIRA

Reviewed By: sc

CC: stack

Differential Revision: https://reviews.facebook.net/D2679 (Revision 1311167)

     Result = FAILURE
mbautin : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java

                
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
>                 Key: HBASE-5744
>                 URL: https://issues.apache.org/jira/browse/HBASE-5744
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>            Priority: Minor
>         Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch, 
> D2685.3.patch, 
> jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make 
> latencies long instead of int everywhere.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to