[
https://issues.apache.org/jira/browse/HBASE-5744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250007#comment-13250007
]
Phabricator commented on HBASE-5744:
------------------------------------
mbautin has abandoned the revision "[jira] [HBASE-5744] Thrift server metrics
should be long instead of int".
Unfortunately, I committed this diff under the 89-fb differential revision
first (D2679) and had to edit the commit message. Here is what I did:
> svn propedit -r 1311167 --revprop svn:log
The new commit message is as follows:
> svn log -r1311167 https://svn.apache.org/repos/asf/hbase/trunk
------------------------------------------------------------------------
r1311167 | mbautin | 2012-04-09 02:00:11 -0700 (Mon, 09 Apr 2012) | 23
lines
[jira] [HBASE-5744] Thrift server metrics should be long instead of int
Summary:
As we measure our Thrift call latencies in nanoseconds, we need to make
latencies long instead of int everywhere. There is a bug where we
truncate a
nanosecond latency to int, which is a problem with RPCs that take more
than
2.147483647 seconds to process.
This is a trunk diff. The 89-fb version of this diff is at D2679.
Test Plan:
TestThriftServer is updated to test for the failure case (an RPC is
artificially
made to take 3 seconds). The new test case fails without the fix.
Re-run all unit tests.
Reviewers: stack, sc, Kannan, JIRA
Reviewed By: sc
Differential Revision: https://reviews.facebook.net/D2685
If you have a git-svn checkout that got confused by this, here is how to get
it back to a consistent state:
git svn reset 1311166
git svn rebase
Sorry about the inconvenience.
REVISION DETAIL
https://reviews.facebook.net/D2685
> Thrift server metrics should be long instead of int
> ---------------------------------------------------
>
> Key: HBASE-5744
> URL: https://issues.apache.org/jira/browse/HBASE-5744
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D2679.1.patch, D2685.1.patch, D2685.2.patch,
> D2685.3.patch,
> jira-HBASE-5744-89-fb-Thrift-server-metrics-should-b-2012-04-07_21_39_35.patch
>
>
> As we measure our Thrift call latencies in nanoseconds, we need to make
> latencies long instead of int everywhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
