bharathv commented on a change in pull request #811: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/811#discussion_r344468460
##########
File path:
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
##########
@@ -871,4 +878,32 @@ private void closeScanner(
handler.scannerGet(scannerId);
handler.scannerClose(scannerId);
}
+
+ @Test
+ public void testGetThriftServerType() throws Exception {
Review comment:
I probably missed this in the last iteration, what is the value add of doing
both this and below?
UTIL starts a full fledged cluster (which includes a proper thrift server),
why run another thrift server in a thread and running the getThriftServerType()
test? My point is that the patch can be simplified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
