bharathv commented on a change in pull request #811: HBASE-20395 Displaying 
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/811#discussion_r344799935
 
 

 ##########
 File path: 
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
 ##########
 @@ -871,4 +878,32 @@ private void closeScanner(
     handler.scannerGet(scannerId);
     handler.scannerClose(scannerId);
   }
+
+  @Test
+  public void testGetThriftServerType() throws Exception {
+    ThriftHBaseServiceHandler handler =
+        new ThriftHBaseServiceHandler(UTIL.getConfiguration(),
+            UserProvider.instantiate(UTIL.getConfiguration()));
+    assertEquals(TThriftServerType.ONE, handler.getThriftServerType());
+  }
+
+  @Test
+  public void testGetThriftServerOneType() throws Exception {
 
 Review comment:
   I see, thanks for the context. Probably helps to add a quick comment to 
clear this up?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to