apurtell commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344839473
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
##########
@@ -868,7 +868,15 @@ public static int transitionNode(ZooKeeperWatcher zkw,
HRegionInfo region,
try {
rt = RegionTransition.createRegionTransition(
endState, region.getRegionName(), serverName, payload);
- if(!ZKUtil.setData(zkw, node, rt.toByteArray(), stat.getVersion())) {
+ boolean isDataSet;
+ try {
+ isDataSet = ZKUtil.setData(zkw, node, rt.toByteArray(),
stat.getVersion());
+ } catch (KeeperException.BadVersionException e) {
Review comment:
BadVersionException signals write-write conflict on the znode. Callers have
to handle it. Down in setData we have no idea what they'd want to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
