apurtell commented on a change in pull request #809: HBASE-23261 : Processing
ZK BadVersionException during node transition
URL: https://github.com/apache/hbase/pull/809#discussion_r344840387
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
##########
@@ -222,9 +229,21 @@ public void completeSplitTransaction(final
RegionServerServices services, Region
// Tell master about split by updating zk. If we fail, abort.
if (coordinationManager.getServer() != null) {
try {
- zstd.setZnodeVersion(transitionSplittingNode(parent.getRegionInfo(),
a.getRegionInfo(),
- b.getRegionInfo(), coordinationManager.getServer().getServerName(),
zstd,
- RS_ZK_REGION_SPLITTING, RS_ZK_REGION_SPLIT));
+ int newNodeVersion = -1;
+ for (int i = 0; i < SPLIT_WAIT_TIMEOUT; i++) {
+ newNodeVersion = transitionSplittingNode(parent.getRegionInfo(),
a.getRegionInfo(),
Review comment:
Let me make an amendment to my earlier statement. I guess one way this could
pass is if the participant we are connected to is behind the leader, and it
catches up, and znode finally has our expectedVersion. But this could be
accomplished with the sync() zk api before the read of the znode instead of a
retry loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
