ndimiduk commented on a change in pull request #807: HBASE-23259: Ability to
start minicluster with pre-determined master ports
URL: https://github.com/apache/hbase/pull/807#discussion_r344965725
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
##########
@@ -1049,6 +1049,21 @@ public MiniHBaseCluster startMiniCluster(int numSlaves)
throws Exception {
return startMiniCluster(option);
}
+ /**
+ * Start up a minicluster of hbase, dfs and zookeeper clusters with given
slave node number and
+ * a set of master ports. All other options will use default values, defined
in
+ * {@link StartMiniClusterOption.Builder}.
+ * @param numSlaves slave node number, for both HBase region server and HDFS
data node.
+ * @see #startMiniCluster(StartMiniClusterOption option)
+ * @see #shutdownMiniDFSCluster()
+ */
+ public MiniHBaseCluster startMiniClusterWithMasterPorts(int numSlaves)
throws Exception {
+ StartMiniClusterOption option = StartMiniClusterOption.builder()
+ .numRegionServers(numSlaves).numDataNodes(numSlaves)
+ .masterPorts(randomFreePorts(1)).build();
Review comment:
In the test environment, why is it that we don't use random ports always?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
