ndimiduk commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#discussion_r347605214
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ########## @@ -171,6 +171,11 @@ /** Configuration key for master web API port */ public static final String MASTER_INFO_PORT = "hbase.master.info.port"; + /** Configuration key for the list of master host:ports **/ + public static final String MASTER_ADDRS_KEY = "hbase.master.addrs"; Review comment: Looking at our zookeeper connection string parsing code. We depend on the Hadoop `Configuration` object to handle parsing of the comma-delimited configuration value. We then manually check for `':'` characters to split out ports. If we're making a habit of doing this kind of parsing (lists of socket addresses), it's probably work encapsulating the logic into a single place. https://github.com/apache/hbase/blob/5e84997f2ffdbcf5f849d70c30ddbe2db4039ca4/hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java#L97-L111 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
